cry/Hyprland
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

renderer: fix popup fadeout blur (#11756)

Browse source 
popups dont get no xray
This commit is contained in:
Vaxry 2025-10-02 12:01:16 +02:00 • committed by GitHub
parent e0c96276df
commit c467bb2640
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 22 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/render/Renderer.cpp
View file

@ -2598,16 +2598,16 @@ void CHyprRenderer::renderSnapshot(WP<CPopup> popup) {
const bool SHOULD_BLUR = shouldBlur(popup); const bool SHOULD_BLUR = shouldBlur(popup);
CTexPassElement::SRenderData data; CTexPassElement::SRenderData data;
data.flipEndFrame = true; data.flipEndFrame = true;
data.tex = FBDATA->getTexture(); data.tex = FBDATA->getTexture();
data.box = {{}, PMONITOR->m_transformedSize}; data.box = {{}, PMONITOR->m_transformedSize};
data.a = popup->m_alpha->value(); data.a = popup->m_alpha->value();
data.damage = fakeDamage; data.damage = fakeDamage;
data.blur = SHOULD_BLUR; data.blur = SHOULD_BLUR;
data.blurA = sqrt(popup->m_alpha->value()); // sqrt makes the blur fadeout more realistic. data.blurA = sqrt(popup->m_alpha->value()); // sqrt makes the blur fadeout more realistic.
data.blockBlurOptimization = SHOULD_BLUR; // force no xray on this (popups never have xray)
if (SHOULD_BLUR) if (SHOULD_BLUR)
data.ignoreAlpha = std::max(*PBLURIGNOREA, 0.01F); /* ignore the alpha 0 regions */ data.ignoreAlpha = std::max(*PBLURIGNOREA, 0.01F); /* ignore the alpha 0 regions */
;
m_renderPass.add(makeUnique<CTexPassElement>(std::move(data))); m_renderPass.add(makeUnique<CTexPassElement>(std::move(data)));
} }

18
src/render/pass/TexPassElement.cpp
View file

@ -36,13 +36,21 @@ void CTexPassElement::draw(const CRegion& damage) {
g_pHyprOpenGL->m_renderData.discardOpacity = *m_data.ignoreAlpha; g_pHyprOpenGL->m_renderData.discardOpacity = *m_data.ignoreAlpha;
} }
if (m_data.blur) if (m_data.blur) {
g_pHyprOpenGL->renderTexture( g_pHyprOpenGL->renderTexture(m_data.tex, m_data.box,
m_data.tex, m_data.box, {
{.a = m_data.a, .blur = true, .blurA = m_data.blurA, .overallA = 1.F, .round = m_data.round, .roundingPower = m_data.roundingPower, .blockBlurOptimization = false}); .a = m_data.a,
else .blur = true,
.blurA = m_data.blurA,
.overallA = 1.F,
.round = m_data.round,
.roundingPower = m_data.roundingPower,
.blockBlurOptimization = m_data.blockBlurOptimization.value_or(false),
});
} else {
g_pHyprOpenGL->renderTexture(m_data.tex, m_data.box, g_pHyprOpenGL->renderTexture(m_data.tex, m_data.box,
{.damage = m_data.damage.empty() ? &damage : &m_data.damage, .a = m_data.a, .round = m_data.round, .roundingPower = m_data.roundingPower}); {.damage = m_data.damage.empty() ? &damage : &m_data.damage, .a = m_data.a, .round = m_data.round, .roundingPower = m_data.roundingPower});
}
} }
bool CTexPassElement::needsLiveBlur() { bool CTexPassElement::needsLiveBlur() {

1
src/render/pass/TexPassElement.hpp
View file

@ -21,6 +21,7 @@ class CTexPassElement : public IPassElement {
CBox clipBox; CBox clipBox;
bool blur = false; bool blur = false;
std::optional<float> ignoreAlpha; std::optional<float> ignoreAlpha;
std::optional<bool> blockBlurOptimization;
}; };
CTexPassElement(const SRenderData& data); CTexPassElement(const SRenderData& data);