From a4e6c5d678e8dd27ab07a6d6eb4ba2834fab81d1 Mon Sep 17 00:00:00 2001 From: nyx Date: Tue, 1 Apr 2025 18:51:37 -0400 Subject: [PATCH] window: don't deactivate unfocused xwayland windows in groups (#9781) * window: don't deactivate unfocused xwayland windows in groups we dont want to deactivate unfocused xwayland windows because X is weird, keep the behavior for wayland windows --- src/desktop/Window.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/desktop/Window.cpp b/src/desktop/Window.cpp index c26e0d9f..41af094b 100644 --- a/src/desktop/Window.cpp +++ b/src/desktop/Window.cpp @@ -1788,9 +1788,11 @@ void CWindow::deactivateGroupMembers() { auto curr = getGroupHead(); while (curr) { if (curr != m_pSelf.lock()) { - if (curr->m_bIsX11) - curr->m_pXWaylandSurface->activate(false); - else if (curr->m_pXDGSurface && curr->m_pXDGSurface->toplevel) + // we dont want to deactivate unfocused xwayland windows + // because X is weird, keep the behavior for wayland windows + // also its not really needed for xwayland windows + // ref: #9760 #9294 + if (!curr->m_bIsX11 && curr->m_pXDGSurface && curr->m_pXDGSurface->toplevel) curr->m_pXDGSurface->toplevel->setActive(false); }