core,hyprctl: clang, clang-tidy, typo fixes and dtors changes (#9233)

* declare dtor once + DMABBUF typo fix

* dup include + clang moment

* linux-dmabuf: last minute nit change

src/render/decorations/CHyprBorderDecoration.cpp

@@ -10,10 +10,6 @@ CHyprBorderDecoration::CHyprBorderDecoration(PHLWINDOW pWindow) : IHyprWindowDec
     ;
 }
 
-CHyprBorderDecoration::~CHyprBorderDecoration() {
-    ;
-}
-
 SDecorationPositioningInfo CHyprBorderDecoration::getPositioningInfo() {
     const auto BORDERSIZE = m_pWindow->getRealBorderSize();
     m_seExtents           = {{BORDERSIZE, BORDERSIZE}, {BORDERSIZE, BORDERSIZE}};

src/render/decorations/CHyprBorderDecoration.hpp

@@ -5,7 +5,7 @@
 class CHyprBorderDecoration : public IHyprWindowDecoration {
   public:
     CHyprBorderDecoration(PHLWINDOW);
-    virtual ~CHyprBorderDecoration();
+    virtual ~CHyprBorderDecoration() = default;
 
     virtual SDecorationPositioningInfo getPositioningInfo();
 

src/render/decorations/CHyprDropShadowDecoration.cpp

@@ -9,8 +9,6 @@ CHyprDropShadowDecoration::CHyprDropShadowDecoration(PHLWINDOW pWindow) : IHyprW
     ;
 }
 
-CHyprDropShadowDecoration::~CHyprDropShadowDecoration() = default;
-
 eDecorationType CHyprDropShadowDecoration::getDecorationType() {
     return DECORATION_SHADOW;
 }

src/render/decorations/CHyprDropShadowDecoration.hpp

@@ -5,7 +5,7 @@
 class CHyprDropShadowDecoration : public IHyprWindowDecoration {
   public:
     CHyprDropShadowDecoration(PHLWINDOW);
-    virtual ~CHyprDropShadowDecoration();
+    virtual ~CHyprDropShadowDecoration() = default;
 
     virtual SDecorationPositioningInfo getPositioningInfo();
 

src/render/decorations/CHyprGroupBarDecoration.cpp

@@ -29,8 +29,6 @@ CHyprGroupBarDecoration::CHyprGroupBarDecoration(PHLWINDOW pWindow) : IHyprWindo
         refreshGroupBarGradients();
 }
 
-CHyprGroupBarDecoration::~CHyprGroupBarDecoration() = default;
-
 SDecorationPositioningInfo CHyprGroupBarDecoration::getPositioningInfo() {
     static auto                PHEIGHT       = CConfigValue<Hyprlang::INT>("group:groupbar:height");
     static auto                PENABLED      = CConfigValue<Hyprlang::INT>("group:groupbar:enabled");
@@ -231,8 +229,6 @@ CTitleTex::CTitleTex(PHLWINDOW pWindow, const Vector2D& bufferSize, const float
         texSize = tex->m_vSize;
 }
 
-CTitleTex::~CTitleTex() = default;
-
 void renderGradientTo(SP<CTexture> tex, CGradientValueData* grad) {
 
     if (!g_pCompositor->m_pLastMonitor)

src/render/decorations/CHyprGroupBarDecoration.hpp

@@ -10,7 +10,7 @@
 class CTitleTex {
   public:
     CTitleTex(PHLWINDOW pWindow, const Vector2D& bufferSize, const float monitorScale);
-    ~CTitleTex();
+    ~CTitleTex() = default;
 
     SP<CTexture> tex;
     std::string  szContent;
@@ -24,7 +24,7 @@ void refreshGroupBarGradients();
 class CHyprGroupBarDecoration : public IHyprWindowDecoration {
   public:
     CHyprGroupBarDecoration(PHLWINDOW);
-    virtual ~CHyprGroupBarDecoration();
+    virtual ~CHyprGroupBarDecoration() = default;
 
     virtual SDecorationPositioningInfo getPositioningInfo();
 

src/render/decorations/IHyprWindowDecoration.cpp

@@ -6,8 +6,6 @@ IHyprWindowDecoration::IHyprWindowDecoration(PHLWINDOW pWindow) : m_pWindow(pWin
     ;
 }
 
-IHyprWindowDecoration::~IHyprWindowDecoration() = default;
-
 bool IHyprWindowDecoration::onInputOnDeco(const eInputType, const Vector2D&, std::any) {
     return false;
 }

src/render/decorations/IHyprWindowDecoration.hpp

@@ -33,7 +33,7 @@ class CDecorationPositioner;
 class IHyprWindowDecoration {
   public:
     IHyprWindowDecoration(PHLWINDOW);
-    virtual ~IHyprWindowDecoration() = 0;
+    virtual ~IHyprWindowDecoration() = default;
 
     virtual SDecorationPositioningInfo getPositioningInfo() = 0;