misc: constify the remaining for loops (#7534)

now we roll loops at blazing constified speed.

src/protocols/core/Compositor.cpp

@@ -241,7 +241,7 @@ void CWLSurfaceResource::frame(timespec* now) {
     if (callbacks.empty())
         return;
 
-    for (auto& c : callbacks) {
+    for (auto const& c : callbacks) {
         c->send(now);
     }
 
@@ -257,7 +257,7 @@ void CWLSurfaceResource::bfHelper(std::vector<SP<CWLSurfaceResource>> nodes, std
     std::vector<SP<CWLSurfaceResource>> nodes2;
 
     // first, gather all nodes below
-    for (auto& n : nodes) {
+    for (auto const& n : nodes) {
         std::erase_if(n->subsurfaces, [](const auto& e) { return e.expired(); });
         // subsurfaces is sorted lowest -> highest
         for (auto const& c : n->subsurfaces) {
@@ -310,7 +310,7 @@ std::pair<SP<CWLSurfaceResource>, Vector2D> CWLSurfaceResource::at(const Vector2
                     void* data) { ((std::vector<std::pair<SP<CWLSurfaceResource>, Vector2D>>*)data)->emplace_back(std::make_pair<>(surf, offset)); },
                  &surfs);
 
-    for (auto& [surf, pos] : surfs | std::views::reverse) {
+    for (auto const& [surf, pos] : surfs | std::views::reverse) {
         if (!allowsInput) {
             const auto BOX = CBox{pos, surf->current.size};
             if (BOX.containsPoint(localCoords))

src/protocols/core/DataDevice.cpp

@@ -80,7 +80,7 @@ void CWLDataOfferResource::sendData() {
         resource->sendAction(WL_DATA_DEVICE_MANAGER_DND_ACTION_MOVE);
     }
 
-    for (auto& m : source->mimes()) {
+    for (auto const& m : source->mimes()) {
         LOGM(LOG, " | offer {:x} supports mime {}", (uintptr_t)this, m);
         resource->sendOffer(m.c_str());
     }

src/protocols/core/Output.cpp

@@ -65,7 +65,7 @@ CWLOutputProtocol::CWLOutputProtocol(const wl_interface* iface, const int& ver,
     IWaylandProtocol(iface, ver, name), monitor(pMonitor), szName(pMonitor->szName) {
 
     listeners.modeChanged = monitor->events.modeChanged.registerListener([this](std::any d) {
-        for (auto& o : m_vOutputs) {
+        for (auto const& o : m_vOutputs) {
             o->updateState();
         }
     });
@@ -95,7 +95,7 @@ void CWLOutputProtocol::destroyResource(CWLOutputResource* resource) {
 }
 
 SP<CWLOutputResource> CWLOutputProtocol::outputResourceFrom(wl_client* client) {
-    for (auto& r : m_vOutputs) {
+    for (auto const& r : m_vOutputs) {
         if (r->client() != client)
             continue;
 

src/protocols/core/Seat.cpp

@@ -525,7 +525,7 @@ void CWLSeatProtocol::updateCapabilities(uint32_t caps) {
 
     currentCaps = caps;
 
-    for (auto& s : m_vSeatResources) {
+    for (auto const& s : m_vSeatResources) {
         s->sendCapabilities(caps);
     }
 }
@@ -534,7 +534,7 @@ void CWLSeatProtocol::updateKeymap() {
     if (!(currentCaps & eHIDCapabilityType::HID_INPUT_CAPABILITY_KEYBOARD))
         return;
 
-    for (auto& k : m_vKeyboards) {
+    for (auto const& k : m_vKeyboards) {
         k->sendKeymap(g_pSeatManager->keyboard.lock());
     }
 }
@@ -543,13 +543,13 @@ void CWLSeatProtocol::updateRepeatInfo(uint32_t rate, uint32_t delayMs) {
     if (!(currentCaps & eHIDCapabilityType::HID_INPUT_CAPABILITY_KEYBOARD))
         return;
 
-    for (auto& k : m_vKeyboards) {
+    for (auto const& k : m_vKeyboards) {
         k->repeatInfo(rate, delayMs);
     }
 }
 
 SP<CWLSeatResource> CWLSeatProtocol::seatResourceForClient(wl_client* client) {
-    for (auto& r : m_vSeatResources) {
+    for (auto const& r : m_vSeatResources) {
         if (r->client() == client)
             return r;
     }

src/protocols/core/Shm.cpp

@@ -171,7 +171,7 @@ CWLSHMResource::CWLSHMResource(SP<CWlShm> resource_) : resource(resource_) {
     });
 
     // send a few supported formats. No need for any other I think?
-    for (auto& s : PROTO::shm->shmFormats) {
+    for (auto const& s : PROTO::shm->shmFormats) {
         resource->sendFormat((wl_shm_format)s);
     }
 }
@@ -193,7 +193,7 @@ void CWLSHMProtocol::bindManager(wl_client* client, void* data, uint32_t ver, ui
             DRM_FORMAT_XBGR8888, DRM_FORMAT_ABGR8888, DRM_FORMAT_XRGB2101010, DRM_FORMAT_ARGB2101010, DRM_FORMAT_XBGR2101010, DRM_FORMAT_ABGR2101010,
         };
 
-        for (auto& fmt : g_pHyprOpenGL->getDRMFormats()) {
+        for (auto const& fmt : g_pHyprOpenGL->getDRMFormats()) {
             if (std::find(supportedShmFourccFormats.begin(), supportedShmFourccFormats.end(), fmt.drmFormat) == supportedShmFourccFormats.end())
                 continue;
 

src/protocols/core/Subcompositor.cpp

@@ -22,7 +22,7 @@ CWLSubsurfaceResource::CWLSubsurfaceResource(SP<CWlSubsurface> resource_, SP<CWL
             return;
 
         auto pushAboveIndex = [this](int idx) -> void {
-            for (auto& c : parent->subsurfaces) {
+            for (auto const& c : parent->subsurfaces) {
                 if (c->zIndex >= idx)
                     c->zIndex++;
             }
@@ -53,7 +53,7 @@ CWLSubsurfaceResource::CWLSubsurfaceResource(SP<CWlSubsurface> resource_, SP<CWL
             return;
 
         auto pushBelowIndex = [this](int idx) -> void {
-            for (auto& c : parent->subsurfaces) {
+            for (auto const& c : parent->subsurfaces) {
                 if (c->zIndex <= idx)
                     c->zIndex--;
             }