From 712bcfbce58a6d352833325bb901fbcf7b58c136 Mon Sep 17 00:00:00 2001 From: UjinT34 <41110182+UjinT34@users.noreply.github.com> Date: Sun, 21 Dec 2025 16:21:51 +0300 Subject: [PATCH] protocols/xdg-shell: fix crash on null parent in pin (#12694) --- src/protocols/XDGShell.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/protocols/XDGShell.cpp b/src/protocols/XDGShell.cpp index ebb56342..969556a3 100644 --- a/src/protocols/XDGShell.cpp +++ b/src/protocols/XDGShell.cpp @@ -257,11 +257,12 @@ CXDGToplevelResource::CXDGToplevelResource(SP resource_, SPm_children.emplace_back(m_self); - if (m_parent->m_window->m_pinned) - m_self->m_window->m_pinned = true; + if (m_parent->m_window && m_parent->m_window->m_pinned) + m_self->m_window->m_pinned = true; + } LOGM(Log::DEBUG, "Toplevel {:x} sets parent to {:x}{}", (uintptr_t)this, (uintptr_t)newp.get(), (oldParent ? std::format(" (was {:x})", (uintptr_t)oldParent.get()) : "")); });