From 42f0a6005b7c502b1486f1f3b4d9883035be3dd8 Mon Sep 17 00:00:00 2001 From: Nikolai Nechaev Date: Sat, 7 Mar 2026 01:33:08 +0900 Subject: [PATCH] keybinds: Remove removed keybinds (#13605) There seems to be no reason for them to remain. But if they are kept, no notification appears to warn a user that a dispatcher used in their config is no longer valid. The config remains valid, but the bindings do not work anymore. --- hyprtester/test.conf | 2 +- src/managers/KeybindManager.cpp | 15 --------------- src/managers/KeybindManager.hpp | 3 --- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/hyprtester/test.conf b/hyprtester/test.conf index e55906e8..ab4f8ee3 100644 --- a/hyprtester/test.conf +++ b/hyprtester/test.conf @@ -250,7 +250,7 @@ bind = $mainMod, E, exec, $fileManager bind = $mainMod, V, togglefloating, bind = $mainMod, R, exec, $menu bind = $mainMod, P, pseudo, # dwindle -bind = $mainMod, J, togglesplit, # dwindle +bind = $mainMod, J, layoutmsg, togglesplit, # dwindle # Move focus with mainMod + arrow keys bind = $mainMod, left, movefocus, l diff --git a/src/managers/KeybindManager.cpp b/src/managers/KeybindManager.cpp index c9c512ae..fd7c4e72 100644 --- a/src/managers/KeybindManager.cpp +++ b/src/managers/KeybindManager.cpp @@ -109,9 +109,6 @@ CKeybindManager::CKeybindManager() { m_dispatchers["togglegroup"] = toggleGroup; m_dispatchers["changegroupactive"] = changeGroupActive; m_dispatchers["movegroupwindow"] = moveGroupWindow; - m_dispatchers["togglesplit"] = toggleSplit; - m_dispatchers["swapsplit"] = swapSplit; - m_dispatchers["splitratio"] = alterSplitRatio; m_dispatchers["focusmonitor"] = focusMonitor; m_dispatchers["movecursortocorner"] = moveCursorToCorner; m_dispatchers["movecursor"] = moveCursor; @@ -1709,18 +1706,6 @@ SDispatchResult CKeybindManager::changeGroupActive(std::string args) { return {}; } -SDispatchResult CKeybindManager::toggleSplit(std::string args) { - return {.success = false, .error = "removed - use layoutmsg"}; -} - -SDispatchResult CKeybindManager::swapSplit(std::string args) { - return {.success = false, .error = "removed - use layoutmsg"}; -} - -SDispatchResult CKeybindManager::alterSplitRatio(std::string args) { - return {.success = false, .error = "removed - use layoutmsg"}; -} - SDispatchResult CKeybindManager::focusMonitor(std::string arg) { const auto PMONITOR = g_pCompositor->getMonitorFromString(arg); tryMoveFocusToMonitor(PMONITOR); diff --git a/src/managers/KeybindManager.hpp b/src/managers/KeybindManager.hpp index db570c8d..1f013606 100644 --- a/src/managers/KeybindManager.hpp +++ b/src/managers/KeybindManager.hpp @@ -194,10 +194,7 @@ class CKeybindManager { static SDispatchResult swapActive(std::string); static SDispatchResult toggleGroup(std::string); static SDispatchResult changeGroupActive(std::string); - static SDispatchResult alterSplitRatio(std::string); static SDispatchResult focusMonitor(std::string); - static SDispatchResult toggleSplit(std::string); - static SDispatchResult swapSplit(std::string); static SDispatchResult moveCursorToCorner(std::string); static SDispatchResult moveCursor(std::string); static SDispatchResult workspaceOpt(std::string);